Merged
Conversation
jrick
approved these changes
Mar 4, 2026
This makes the connmgr package an internal package such that it will no longer be an exported module. The only place its functionality is really needed is for the internal implementation of dcrd itself and thus having an unnecessary exported module significantly increases the maintenance burden. It is worth noting that there are a few things, which will be listed below, that were exported from this module that callers might have previously relied upon. These things have been moved to the address manager module. The aforementioned methods and types are: - TorLookupIP method and all associated ErrX constants - HttpsSeederFilters struct - DialFunc method - SeedFilterIPVersion method - SeedFilterProtocolVersion method - SeedFilterServices method - SeedAddrs method Overview of the major changes: - Move the following files from connmgr -> internal/connmgr: - README.md - connmanager.go - connmanager_test.go - doc.go - dynamicbanscore.go - dynamicbanscore_test.go - error.go - error_test.go - log.go - Remove connmgr/go.mod and connmgr/go.sum - Make the README.md and docs.go files match the new reality - Update all import paths in the repository accordingly - Remove the dependency from the root go.mod - Run go mod tidy on all modules
This modifies the multimod go workspace setup script to remove the connmgr module now that it is an internal package. It also adds a directive to drop the use of the connmgr module from existing go.work files.
7dc8ad8 to
5e1b5d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This requires #3634, #3635, and #3636.
This makes the
connmgrpackage an internal package such that it will no longer be an exported module. The only place its functionality is really needed is for the internal implementation ofdcrditself and thus having an unnecessary exported module significantly increases the maintenance burden.It is worth noting that there are a few things, which will be listed below, that were exported from this module that callers might have previously relied upon. These things have been moved to the address manager module.
The aforementioned methods and types are:
TorLookupIPmethod and all associatedErrXconstantsHttpsSeederFiltersstructDialFuncmethodSeedFilterIPVersionmethodSeedFilterProtocolVersionmethodSeedFilterServicesmethodSeedAddrsmethodOverview of the major changes:
connmgr->internal/connmgr:README.mdconnmanager.goconnmanager_test.godoc.godynamicbanscore.godynamicbanscore_test.goerror.goerror_test.golog.goconnmgr/go.modandconnmgr/go.sumREADME.mdanddocs.gofiles match the new realitygo.modgo mod tidyon all modules